ImperialLinkedIn#123
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #123 +/- ##
==========================================
+ Coverage 82.41% 82.98% +0.56%
==========================================
Files 59 63 +4
Lines 802 852 +50
==========================================
+ Hits 661 707 +46
- Misses 141 145 +4
🚀 New features to boost your workflow:
|
fpseverino
requested changes
Oct 10, 2025
fpseverino
left a comment
fpseverino
left a comment
Member
There was a problem hiding this comment.
Great job, thank you very much! Just a few minor oversights to point out
Comment on lines
+40
to
+41
| print("====") | ||
| print(url.absoluteString) |
Member
There was a problem hiding this comment.
These prints may be left over from debugging, please remove them
Contributor
Author
There was a problem hiding this comment.
Yes, thank you for pointing it out. Oversaw it and will fix it.
Co-authored-by: Francesco Paolo Severino <96546612+fpseverino@users.noreply.github.com>
Co-authored-by: Francesco Paolo Severino <96546612+fpseverino@users.noreply.github.com>
Co-authored-by: Francesco Paolo Severino <96546612+fpseverino@users.noreply.github.com>
Contributor
Author
|
@fpseverino Hi, didn't want to request a review instantly. Was a mistake. I apologize. |
Member
No worries 😉👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add ImperialLinkedIn
@fpseverino